Add The House in Fata Morgana #980
Open
+83
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mansive
reviewed
Jan 19, 2026
| Interceptor.attach(address, function (args) { | ||
| try { | ||
| const basePtr = this.context[register]; | ||
|
|
Collaborator
There was a problem hiding this comment.
Instead of wrapping the entire function in a try-catch block to guard against null pointers, you can instead use if-statements to check for them and do an early return. NativePointer objects like basePtr have an isNull() method you can use.
|
|
||
| // only output japanese characters and no duplicates | ||
| if (cleaned.length > 0 && | ||
| /[\u3040-\u30FF\u4E00-\u9FAF]/.test(cleaned) && |
Collaborator
There was a problem hiding this comment.
This regex test can be put into its own function like you’ve done for endsWithPunctuation()
… detection into named function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.